Modify configs earlier; Support sourceCompatibility #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved projectsEvaluated back to where it was, which seems to work now :/. Allow use on new JDKs when sourceCompatibility is set to supported version. Defer to sourceCompatibility default use of JavaVersion.
mwhipple
commented
Jan 29, 2019
| if (!userConfig.checkers.empty) { | ||
| compile.options.compilerArgs << "-processor" << userConfig.checkers.join(",") | ||
| } | ||
| project.gradle.projectsEvaluated { |
There was a problem hiding this comment.
It seems like using this hook shouldn't be needed given the behavior of the TaskContainer/DomainObjectCollection#withType below, but tests start failing without it (maybe an issue with other defaults clobbering these values or something).
|
I'm the original reporter of #13, and I just tested this out myself and it looks fantastic. Thanks :) |
|
Is there a time table for when this will be merged and a new release will come out? Let me know if there's anything I can do to help. |
|
Can you update this so we can merge it? |
|
sure thing, I'll grab some time this week to dust this off |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved projectsEvaluated back to where it was, which seems to work now :/.
Allow use on new JDKs when sourceCompatibility is set to supported version.
Defer to sourceCompatibility default use of JavaVersion.